Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster setting cluster.restrict.index.replication_type t… (#10866) #10876

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add cluster setting cluster.restrict.index.replication_type t… (#10866) #10876

merged 1 commit into from
Oct 24, 2023

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Oct 23, 2023 •
edited
Loading

  • Add cluster setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING to restrict setting of index setting replication type

  • Add Changelog entry

  • refactoring

Description

Backport #10866 to 2.x

@Poojita-Raj
Add cluster setting cluster.restrict.index.replication_type t… (opens…
f25243f 
…earch-project#10866)

* Add cluster setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING to restrict setting of index setting replication type

Signed-off-by: Poojita Raj <[email protected]>

* Add Changelog entry

Signed-off-by: Poojita Raj <[email protected]>

* refactoring

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change f25243f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

#10542

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/28882/

* **CommitID:** [f25243f](https://github.com/opensearch-project/OpenSearch/commit/f25243f271083a04cbcaf146ab5fabdbb7514829)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#10006
#10154
#10798

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #10876 (f25243f) into 2.x (71d89ca) will increase coverage by 0.04%.
Report is 4 commits behind head on 2.x.
The diff coverage is 72.18%.

@@             Coverage Diff              @@
##                2.x   #10876      +/-   ##
============================================
+ Coverage     70.93%   70.97%   +0.04%     
- Complexity    58736    58816      +80     
============================================
  Files          4844     4844              
  Lines        277352   277472     +120     
  Branches      40683    40705      +22     
============================================
+ Hits         196736   196933     +197     
+ Misses        63886    63834      -52     
+ Partials      16730    16705      -25
Files Coverage Δ
...earch/action/search/AbstractSearchAsyncAction.java 79.72% <100.00%> (+0.11%) ⬆️
...g/opensearch/action/search/MultiSearchRequest.java 80.34% <100.00%> (+0.46%) ⬆️
...opensearch/action/search/SearchResponseMerger.java 78.81% <100.00%> (+0.10%) ⬆️
...h/cluster/metadata/MetadataCreateIndexService.java 79.69% <100.00%> (+0.55%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...rg/opensearch/index/translog/RemoteFsTranslog.java 74.63% <100.00%> (-0.49%) ⬇️
...in/java/org/opensearch/indices/IndicesService.java 70.63% <100.00%> (-0.54%) ⬇️
...va/org/opensearch/action/search/SearchRequest.java 82.81% <81.81%> (+1.10%) ⬆️
...arch/gateway/remote/RemoteClusterStateService.java 70.84% <87.50%> (+0.86%) ⬆️
... and 4 more

... and 445 files with indirect coverage changes

@mch2 mch2 merged commit 83b0371 into opensearch-project:2.x Oct 24, 2023
66 checks passed
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 2, 2023
@Poojita-Raj
Revert "Add cluster setting cluster.restrict.index.replication_type t… (
c54dff6 
opensearch-project#10866) (opensearch-project#10876)"

This reverts commit 83b0371.
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Nov 2, 2023
@Poojita-Raj
Revert "Add cluster setting cluster.restrict.index.replication_type t… (
562c08a 
opensearch-project#10866) (opensearch-project#10876)"

This reverts commit 83b0371.

Signed-off-by: Poojita Raj <[email protected]>
@Poojita-Raj Poojita-Raj mentioned this pull request Nov 2, 2023
Merged
8 tasks
dreamer-89 pushed a commit that referenced this pull request Nov 7, 2023
@Poojita-Raj
Revert "Add cluster setting cluster.restrict.index.replication_type t… (
342cc17 
#10866) (#10876)" (#11073)

This reverts commit 83b0371.

Signed-off-by: Poojita Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rishikesh1159 Rishikesh1159 Rishikesh1159 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poojita-Raj @mch2 @Rishikesh1159